Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fileinput): standalone page for FileInput component #1132

Merged
merged 1 commit into from
Nov 20, 2023
Merged

docs(fileinput): standalone page for FileInput component #1132

merged 1 commit into from
Nov 20, 2023

Conversation

MateoWartelle
Copy link
Contributor

Summarize the changes made and the motivation behind them.

To create separate pages for /forms/* documentations to match flowbite of existing react components.

Reference related issues using # followed by the issue number.

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 11:38am

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7461173) 99.54% compared to head (114f078) 93.60%.
Report is 153 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   99.54%   93.60%   -5.95%     
==========================================
  Files         163      213      +50     
  Lines        6621     9048    +2427     
  Branches      401      483      +82     
==========================================
+ Hits         6591     8469    +1878     
- Misses         30      579     +549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/docs/forms/file-input.mdx Outdated Show resolved Hide resolved
@MateoWartelle
Copy link
Contributor Author

Ill rebase and it should be good to merge.

@MateoWartelle
Copy link
Contributor Author

ok should be good to go.

thanks

@rluders
Copy link
Collaborator

rluders commented Nov 20, 2023

@SutuSebastian
Copy link
Collaborator

@MateoWartelle don't we want to remove it from here? https://flowbite-react-git-fork-mateowartelle-docs-fileinput-themesberg.vercel.app/docs/components/forms#file-upload

I actually discussed this subject with @zoltanszogyenyi a couple of days ago and we want to keep the components/forms/* page as an overall form components examples, and each form component should have its own page under forms/* with even more detailed implementation and examples.

@rluders rluders merged commit ce72ce7 into themesberg:main Nov 20, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants