-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(fileinput): standalone page for FileInput component #1132
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
- Coverage 99.54% 93.60% -5.95%
==========================================
Files 163 213 +50
Lines 6621 9048 +2427
Branches 401 483 +82
==========================================
+ Hits 6591 8469 +1878
- Misses 30 579 +549 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ill rebase and it should be good to merge. |
ok should be good to go. thanks |
@MateoWartelle don't we want to remove it from here? https://flowbite-react-git-fork-mateowartelle-docs-fileinput-themesberg.vercel.app/docs/components/forms#file-upload |
I actually discussed this subject with @zoltanszogyenyi a couple of days ago and we want to keep the |
Summarize the changes made and the motivation behind them.
To create separate pages for /forms/* documentations to match flowbite of existing react components.
Reference related issues using
#
followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.