Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/list props warning #1138

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

paghar
Copy link
Contributor

@paghar paghar commented Nov 17, 2023

Summarize the changes made and the motivation behind them.

Reference related issues using # followed by the issue number.

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 9:39pm

@paghar
Copy link
Contributor Author

paghar commented Nov 17, 2023

This PR is ready to be merged!

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7461173) 99.54% compared to head (f749ce5) 93.60%.
Report is 152 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   99.54%   93.60%   -5.95%     
==========================================
  Files         163      213      +50     
  Lines        6621     9048    +2427     
  Branches      401      483      +82     
==========================================
+ Hits         6591     8469    +1878     
- Misses         30      579     +549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@rluders rluders merged commit 8550e7e into themesberg:main Nov 20, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants