Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use promises instead of callbacks #79

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

relative2
Copy link

@relative2 relative2 commented Dec 27, 2017

Promises are better than callbacks because you can use node's await to call the function so no function nesting is needed.

Please review the code before merging :)

This also implements #56 by @BasKiers and #68 by @angelnu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant