fix: crash when checking for pragmas and docs in very long procedures

FossilOrigin-Name: ce9154a7b54bb2be562784ddbd13f265fca8974a0cc33f245d30e4d8aea41406
thindil · Jan 29, 2025 · 47ffc0e · 47ffc0e
1 parent 35700b4
commit 47ffc0e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 11 deletions.
diff --git a/src/rules/hasdoc.nim b/src/rules/hasdoc.nim
@@ -161,10 +161,13 @@ checkRule:
               return
         try:
           let routineHash: Hash = hash(x = nodeName & $node[paramsPos])
-          if ($node[bodyPos]).len == 0:
-            checked.add(y = routineHash)
-          elif routineHash in checked:
-            continue
+          try:
+            if ($node[bodyPos]).len == 0:
+              checked.add(y = routineHash)
+            elif routineHash in checked:
+              continue
+          except Exception:
+            discard
         except Exception:
           rule.amount = errorMessage(
               text = "Can't check if thing is a forward declaration.")

diff --git a/src/rules/haspragma.nim b/src/rules/haspragma.nim
@@ -1,4 +1,4 @@
-# Copyright © 2023-2024 Bartek Jasicki
+# Copyright © 2023-2025 Bartek Jasicki
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -161,13 +161,16 @@ checkRule:
             return
       try:
         let routineHash: Hash = hash(x = procName & $node[paramsPos])
-        if ($node[bodyPos]).len == 0:
-          checked.add(y = routineHash)
-        elif routineHash in checked:
-          continue
+        try:
+          if ($node[bodyPos]).len == 0:
+            checked.add(y = routineHash)
+          elif routineHash in checked:
+            continue
+        except Exception:
+          discard
       except Exception:
-        rule.amount = errorMessage(
-            text = "Can't check if thing is a forward declaration.")
+        rule.amount = errorMessage(text = "Can't check if thing is a forward declaration.",
+            e = getCurrentException())
         return
       # The node doesn't have any pragmas
       if pragmas == nil: