Skip to content

Commit

Permalink
feat: better messages about results of objects rule check
Browse files Browse the repository at this point in the history
FossilOrigin-Name: ebb60e5691124b4f2f79aec9c18721d490b66418ce241e8dd4bc4643626fc4d5
  • Loading branch information
thindil committed Apr 5, 2024
1 parent e9c65b0 commit d2800a7
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions src/rules/objects.nim
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ import ../rules
ruleConfig(ruleName = "objects",
ruleFoundMessage = "object's types declarations which can{negation} be upgraded",
ruleNotFoundMessage = "object's types declarations which can{negation} be upgraded not found.",
rulePositiveMessage = "object's type declaration, line: {params[0]} {params[1]}",
ruleNegativeMessage = "object's type declaration, line: {params[0]} {params[1]}",
rulePositiveMessage = "declaration of type '{params[2]}', line: {params[0]} {params[1]}",
ruleNegativeMessage = "declaration of type '{params[2]}', line: {params[0]} {params[1]}",
ruleOptions = @[custom],
ruleOptionValues = @["publicfields"],
ruleMinOptions = 1)
Expand All @@ -115,9 +115,15 @@ checkRule:
if rule.ruleType in {RuleTypes.count, search}:
checkResult = not checkResult
let oldAmount: int = rule.amount
setResult(checkResult = checkResult, positiveMessage = positiveMessage,
negativeMessage = negativeMessage, ruleData = "public fields",
node = node, params = [$node.info.line, message])
try:
setResult(checkResult = checkResult, positiveMessage = positiveMessage,
negativeMessage = negativeMessage, ruleData = "public fields",
node = node, params = [$node.info.line, message, $astNode[0]])
except Exception:
rule.amount = errorMessage(text = messagePrefix &
"can't check declaration of type " &
" line: " &
$node.info.line & ". Reason: ", e = getCurrentException())
# To show the rule's explaination the rule.amount must be negative
if rule.negation and oldAmount > rule.amount and rule.ruleType == check:
rule.amount = -1_000
Expand Down

0 comments on commit d2800a7

Please sign in to comment.