Fix linter errors

.github/workflows/build-test-lint.yml

@@ -20,7 +20,7 @@ jobs:
         nix build
     - name: Test
       run: |
-        nix develop --ignore-environment --command "cargo" "test"
+        nix build .#test
     - name: Lint
       run: |
-        nix develop --ignore-environment --command "cargo" "clippy"
+        nix build .#clippy

flake.nix

@@ -34,7 +34,19 @@
         };
 
       in rec {
-        defaultPackage = naersk'.buildPackage { src = ./.; };
+        packages = {
+          default = naersk'.buildPackage {
+            src = ./.;
+          };
+          test = naersk'.buildPackage {
+            src = ./.;
+            mode = "test";
+          };
+		  clippy = naersk'.buildPackage {
+            src = ./.;
+            mode = "clippy";
+          };
+        };
 
         devShell = pkgs.mkShell { nativeBuildInputs = [ toolchain pkgs.rust-analyzer ]; };
       });

src/main.rs

@@ -1,19 +1,19 @@
-use crate::app::App;
+use crate::taskui::{App, Config};
 use anyhow::Result;
-use app::{
+use ratatui::{backend::CrosstermBackend, Terminal};
+use taskui::{
     event::{Event, EventHandler},
     terminal::UserInterface,
     update,
 };
-use ratatui::{backend::CrosstermBackend, Terminal};
 
-mod app;
 mod taskfile;
+mod taskui;
 
 fn main() -> Result<()> {
     let taskfile = taskfile::config::load()?;
 
-    let cfg = app::Config::load();
+    let cfg = Config::load();
     let mut app = App::new(cfg, taskfile);
 
     let backend = CrosstermBackend::new(std::io::stderr());

src/taskfile/config.rs

@@ -32,14 +32,14 @@ pub fn load() -> Result<Vec<Task>> {
         current_path.to_str().unwrap(),
     )?;
 
-    tasks.extend(included_tasks.into_iter());
+    tasks.extend(included_tasks);
 
     Ok(tasks)
 }
 
 fn find_supported_file() -> Result<&'static str> {
     // https://taskfile.dev/usage/#supported-file-names
-    let file_names = vec![
+    let file_names = [
         "Taskfile.yml",
         "taskfile.yml",
         "Taskfile.yaml",
@@ -53,7 +53,7 @@ fn find_supported_file() -> Result<&'static str> {
     let found = file_names
         .iter()
         .find(|&file_name| metadata(file_name).is_ok())
-        .map(|&file_name| file_name);
+        .copied();
 
     match found {
         Some(file_name) => Ok(file_name),
@@ -175,7 +175,7 @@ fn extract_include_path(include_yml: &Value) -> Result<String> {
         Value::String(path) if path.ends_with(".yml") || path.ends_with(".yaml") => {
             path.to_string()
         }
-        Value::String(path) if path.ends_with("/") => format!("{}Taskfile.yml", path),
+        Value::String(path) if path.ends_with('/') => format!("{}Taskfile.yml", path),
         Value::String(path) => format!("{}/Taskfile.yml", path),
         Value::Mapping(v) => {
             if let Some(taskfile) = v.get(&Value::String("taskfile".to_string())) {

src/app/app.rs → src/taskui/app.rs

@@ -69,7 +69,7 @@ impl StatefulList {
     }
 
     pub fn next(&mut self) {
-        if self.items.len() == 0 {
+        if self.items.is_empty() {
             self.reset_selected();
             return;
         }
@@ -89,7 +89,7 @@ impl StatefulList {
     }
 
     pub fn previous(&mut self) {
-        if self.items.len() == 0 {
+        if self.items.is_empty() {
             self.reset_selected();
             return;
         }
@@ -122,11 +122,11 @@ impl StatefulList {
     }
 
     pub fn filter(&mut self, search: &String) {
-        self.items = self.orig_items.clone();
+        self.items.clone_from(&self.orig_items);
         self.items.retain(|i| i.item.name.contains(search));
         self.state = ListState::default();
 
-        if self.items.len() > 0 {
+        if !self.items.is_empty() {
             self.state.select(Some(0));
         } else {
             self.state.select(None);