Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Rails 5.2, Ruby 2.7, and add support Rails 7.1 #318

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Drop support for Rails 5.2, Ruby 2.7, and add support Rails 7.1 #318

merged 10 commits into from
Mar 25, 2024

Conversation

stefannibrasil
Copy link
Contributor

@stefannibrasil stefannibrasil commented Mar 19, 2024 •
edited
Loading

It's time.

  • drop support to this Rails version: allow us to bump some of the dev dependencies versions.
  • add minimum ruby version required to run the repo: 3.0
  • add support for rails 7.1
  • add support for ruby 3.3
  • fix some deprecation warnings

Stefanni Brasil added 5 commits March 19, 2024 15:34
Require ruby >= 3.0.0
6332ae8
Drop support for Rails 5.2
9e5d5aa
Bump activesupport and rspec-rails versions
b0d4be2 
Dropping support to rails 5.2 allows us to bump these
versions.
Remove rspec-rails calls from each gemfile
ee83154 
This warning was being displayed by keeping this block:

```
Your Gemfile lists the gem rspec-rails (~> 5.0.0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
```

I don't know why they were added but they seem to not be needed anymore.
Remove unnecessary deprecator silence block
e6e6d9a 
This block was added when caching was deprecated. It's been a long
time since we don't support native caching anymore, so we don't need
to silence any deprecations here.
stefannibrasil
stefannibrasil commented Mar 19, 2024
View reviewed changes
spec/high_voltage/configuration_spec.rb
@@ -6,13 +6,11 @@

before(:each) do
HighVoltage.configure do |config|
ActiveSupport::Deprecation.silence do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActiveSupport::Deprecation.silence is deprecated. I was going to make this work with the new available API but then I realized we don't actually need this block anymore. It was added back when we deprecated caching. It's been a long time -- removing it doesn't even generate any warnings.

@stefannibrasil stefannibrasil changed the title Drop support for Rails 5.2 and support Rails 7.1 Drop support for Rails 5.2, Ruby 2.7, and add support Rails 7.1 Mar 19, 2024
mike-burns
mike-burns approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@mike-burns mike-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor.

BTW, something I learned while doing this to factory_bot is that people expect this to lead to a major version bump.

@stefannibrasil
Copy link
Contributor Author

stefannibrasil commented Mar 19, 2024 •
edited
Loading

Yep! Agreed. There are some unreleased items in the CHANGELOG that could go in this release. I might not have the time to do the release -- will let you know in case you can help.

I'm testing this branch on a new Rails app as well.

Tested on a new Rails s 7.1.3.2 app. All good 👍

MatheusRich
MatheusRich approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@MatheusRich MatheusRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Can we release this a release candidate to see if there's anything we missed?

@stefannibrasil
Copy link
Contributor Author

Sounds good. Can we release this a release candidate to see if there's anything we missed?

That's a great idea! Gonna do that today.

@stefannibrasil
Copy link
Contributor Author

For reference: I asked @emilford to try out this branch on a client's project using high_voltage. The result:

No issues after having updated to your branch. 🙌

@stefannibrasil stefannibrasil merged commit d79759f into main Mar 25, 2024
18 checks passed
@stefannibrasil stefannibrasil deleted the sb-drop-rails-eol branch March 25, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-burns mike-burns mike-burns approved these changes

@MatheusRich MatheusRich MatheusRich approved these changes

@brian-penguin brian-penguin Awaiting requested review from brian-penguin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefannibrasil @mike-burns @MatheusRich