Added Rails 8.0 to the test matrix

[luizkowalski]

Following up on #336, I think it's best to do on a separated branch

[emilford]

@luizkowalski, thanks! I think you also need to update build strategy matrix.

[luizkowalski]

oh wow totally missed this! pushed it now

[luizkowalski]

hey 👋🏻
can we merge this? I'm planning on tackle #332 but would like to avoid conflicts

[luizkowalski]

for some reason, I had to now add activemodel dependency because I kept getting errors saying it was not defined/found. Also manually requiring logger because Concurrent Ruby dropped the requirement and I don't think that the fix was backported to all versions

[emilford]

warning: mutex_m was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.
You can add mutex_m to your Gemfile or gemspec to silence this warning.

This look related to the failures on the Ruby 3.4 + Rails 6.1/7.0 build. Are you able to look into these?

warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.

It's a warning, but what do you think about resolving it to stay ahead?

[emilford]

Did we need to drop Rails 6.0 support as a part of this PR or could that be done separately?

[luizkowalski]

Did we need to drop Rails 6.0 support as a part of this PR or could that be done separately?

It can be done separately but I figure that since we are already adding a new version here, we could save some time and do it here.

I'm not strong about it though, if you want I can open a separate PR

[luizkowalski]

I readded 6.0 and added these dependencies on the Appraisal file, not on the gemspec, I think it is the right place since these are test-only dependencies

[emilford]

Hey, @luizkowalski. I had other things on the plate today and just now getting back to this. Looking at this again, I think there's a couple of things here that I think we want to address.

I think it was a mistake on our part to require Ruby >= 3.x and to continue to support Rails 6.0 since it supports Ruby >= 2.5.0 < 3.0.0. I'm inclined to go ahead and drop support for it. Rails 6.1 was also EOL'd end of last year, so we could drop support for it as well.

That makes Rails 7.0.x the minimum supported version, which aligns with Rails' currently supported versions. We'll still need to add the missing dependencies, but could you make them specific to the Rails 7.0 gems instead of all Rails versions. You can wrap them in a conditional.

[luizkowalski]

no worries, makes sense. I pushed the changes and also increased the Ruby minimum, version since 3.0 support ended 9 months ago

I'm fine with reverting it since 3.0 is still ok with Rails 7.0 (it requires Ruby >= 2.7.0)

[emilford]

@luizkowalski thanks for your work on this. 👍