Comment

tighten · May 16, 2024 · 39a13c6 · 39a13c6
1 parent 6f88d0c
commit 39a13c6
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/js/Route.js b/src/js/Route.js
@@ -116,6 +116,8 @@ export default class Route {
 
         if (!segments.length) return this.template;
 
+        // This should probably be refactored to build the host and path separately (not the entire URL at once)
+        // because that's how Laravel does it internally and it's more precise and less error-prone
         return this.template
             .replace(/{([^}?]+)(\??)}/g, (_, segment, optional) => {
                 // If the parameter is missing but is not optional, throw an error