Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyspace: Asynchronously pre-allocate keyspaces #9019

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Jan 24, 2025

What problem does this PR solve?

Issue Number: Close #9022

What is changed and how does it work?

keyspace: Asynchronously pre-allocate keyspaces to improve startup performance (mainly for test).

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

keyspace: Asynchronously pre-allocate keyspaces to improve startup performance (mainly for test).

* keyspace: Async create pre-alloc keyspaces

Signed-off-by: Ping Yu <[email protected]>

* fix ut

Signed-off-by: Ping Yu <[email protected]>

* fix fmt

Signed-off-by: Ping Yu <[email protected]>

* create parallel; fix ut

Signed-off-by: Ping Yu <[email protected]>

* fix lint

Signed-off-by: Ping Yu <[email protected]>

* fix lint

Signed-off-by: Ping Yu <[email protected]>

* fix lint

Signed-off-by: Ping Yu <[email protected]>

* fix ut; set fast-fail to false

Signed-off-by: Ping Yu <[email protected]>

* fix ut

Signed-off-by: Ping Yu <[email protected]>

* fix ut

Signed-off-by: Ping Yu <[email protected]>

* fix data race

Signed-off-by: Ping Yu <[email protected]>

* increase concurrency

Signed-off-by: Ping Yu <[email protected]>

* wait keyspaces created

Signed-off-by: Ping Yu <[email protected]>

* add comments

Signed-off-by: Ping Yu <[email protected]>

* polish

Signed-off-by: Ping Yu <[email protected]>

* more wait keyspaces

Signed-off-by: Ping Yu <[email protected]>

* improve wait keyspaces

Signed-off-by: Ping Yu <[email protected]>

* fix TestKeyspace

Signed-off-by: Ping Yu <[email protected]>

* fix not determined keyspace id

Signed-off-by: Ping Yu <[email protected]>

---------

Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jan 24, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign huachaohuang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2025
Signed-off-by: Ping Yu <[email protected]>
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.23%. Comparing base (6cadbe7) to head (274a9fd).
Report is 1 commits behind head on master.

❌ Your patch check has failed because the patch coverage (47.82%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9019      +/-   ##
==========================================
- Coverage   76.25%   76.23%   -0.02%     
==========================================
  Files         466      466              
  Lines       70733    70734       +1     
==========================================
- Hits        53938    53925      -13     
- Misses      13437    13448      +11     
- Partials     3358     3361       +3     
Flag Coverage Δ
unittests 76.23% <47.82%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pingyu pingyu changed the title keyspace: Async pre alloc keyspaces keyspace: Asynchronously pre alloc keyspaces Jan 26, 2025
@pingyu
Copy link
Contributor Author

pingyu commented Jan 26, 2025

/retest

@pingyu pingyu changed the title keyspace: Asynchronously pre alloc keyspaces keyspace: Asynchronously pre allocate keyspaces Jan 26, 2025
@pingyu pingyu changed the title keyspace: Asynchronously pre allocate keyspaces keyspace: Asynchronously pre-allocate keyspaces Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyspace: Asynchronously pre allocate keyspaces on start up
1 participant