Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Transit Gateway #3748

Draft
wants to merge 8 commits into
base: latest
Choose a base branch
from
Draft

AWS Transit Gateway #3748

wants to merge 8 commits into from

Conversation

atovpeko
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-266-transit-gateway-addition-in-docs

billy-the-fish
billy-the-fish approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc. Couple of annoying niggles.

use-timescale/security/transit-gateway.md Outdated Show resolved Hide resolved
use-timescale/security/transit-gateway.md Outdated Show resolved Hide resolved
use-timescale/security/transit-gateway.md Outdated Show resolved Hide resolved
use-timescale/security/transit-gateway.md Outdated Show resolved Hide resolved
@atovpeko atovpeko marked this pull request as draft January 24, 2025 16:47
miqrc
miqrc reviewed Jan 27, 2025
View reviewed changes
Copy link

@miqrc miqrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs 💯
I added some suggestions. Also, Transit Gateway feature is only available for Scale and Enterprise plans. I don't know if we should add this somewhere in the doc.

use-timescale/security/transit-gateway.md Outdated Show resolved Hide resolved
use-timescale/security/transit-gateway.md Outdated Show resolved Hide resolved
use-timescale/security/transit-gateway.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miqrc miqrc miqrc left review comments

@esclymeTS esclymeTS esclymeTS approved these changes

@billy-the-fish billy-the-fish billy-the-fish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atovpeko @billy-the-fish @miqrc @esclymeTS