Add origin parameter to time_bucket_gapfill

[syvb]

Allows specifying an origin for time_bucket_gapfill.

I added the origin parameter after start/finish since adding it before would make calls with a third argument ambiguous – it could refer to either the start or origin: with time_bucket_gapfill(..., ..., '2022-01-01') the last argument could refer to start or origin. The API I defined in this I added a optional origin argument at the end, after start/finish. Normally users should specify as a named argument. This makes the API somewhat inconsistent, since timezone is before the start/finish.

This change has to be a modification of the existing function, since origin is after the start/finish arguments which default to NULL, and all arguments after an argument with a default must also have defaults. Changing the function means that upgrades require dropping it and recreating it, which would break existing views that rely on time_bucket_gapfill. We could work around this by renaming the old functions (to something like _timescaledb_internal.time_bucket_gapfill_old) so that existing views don't break.

Other API options:

• Creating a new time_bucket_gapfill_ng function
• Making the origin argument the first argument so there wouldn't be any ambiguity

I still need to add some tests and update the update/downgrade scripts.

cc @davidkohn88
Partially addresses #3212.

[LoganSurmount]

Please remove me from notifications for this.

On Fri, Mar 24, 2023 at 8:28 PM Smittyvb ***@***.***> wrote: Partially addresses #3212 <#3212>. I added the parameter after start/finish since adding it before would make calls with a third argument ambiguous – it could refer to either the start or origin. I still need to add some tests and update the update/downgrade scripts so that existing uses of time_bucket_gapfill in a view aren't broken. cc @davidkohn88 <https://github.com/davidkohn88> ------------------------------ You can view, comment on, or merge this pull request online at: #5485 Commit Summary - 26c62f6 <26c62f6> Support origin parameter to time_bucket_gapfill File Changes (12 files <https://github.com/timescale/timescaledb/pull/5485/files>) - *M* sql/gapfill.sql <https://github.com/timescale/timescaledb/pull/5485/files#diff-5e981bb50d6e5c35388567da8ce46f11ea4d66b4ff0eafeecf88ae628e911f01> (10) - *M* src/compat/compat.h <https://github.com/timescale/timescaledb/pull/5485/files#diff-43ecbae21481d1771c78fe794ba2984af0a010fbf823878234615e0b72f81856> (3) - *M* src/cross_module_fn.c <https://github.com/timescale/timescaledb/pull/5485/files#diff-f9a5820a03bc604ab731eb0dbc5d7036a6d2e3a1a90c333b1cf820131971c933> (2) - *M* src/cross_module_fn.h <https://github.com/timescale/timescaledb/pull/5485/files#diff-96ba37f89f172f8ddd3297b7cbab2a38e2005d029c059d71b24091cfd5b56937> (2) - *M* src/func_cache.c <https://github.com/timescale/timescaledb/pull/5485/files#diff-fc5b01777634285074424e085d28b525cfbe6aebd0a35045a3b385c93fa48e0a> (23) - *M* src/gapfill.c <https://github.com/timescale/timescaledb/pull/5485/files#diff-83bcb4aad2c3e206cb6a3a59c0af53c52cdcf63e769f949b0b3dfe5d7dcd490e> (2) - *M* tsl/src/init.c <https://github.com/timescale/timescaledb/pull/5485/files#diff-92fead201d3394cb005769032edebf36b3a38227f999218d890db599c6361909> (2) - *M* tsl/src/nodes/gapfill/gapfill_exec.c <https://github.com/timescale/timescaledb/pull/5485/files#diff-7d8d2bb2e57d2ad091c661cb61d9e08486efafe6d74b15b919860c5abf122bc6> (48) - *M* tsl/src/nodes/gapfill/gapfill_functions.c <https://github.com/timescale/timescaledb/pull/5485/files#diff-c053209d883e849456f07645a327f9afb2870223597af255fbd97939cc692cff> (33) - *M* tsl/src/nodes/gapfill/gapfill_functions.h <https://github.com/timescale/timescaledb/pull/5485/files#diff-7fb0017fa105c285bfeb75f0f393378aec34a089531bee58cff6c00858a0c2c5> (2) - *M* tsl/src/nodes/gapfill/gapfill_internal.h <https://github.com/timescale/timescaledb/pull/5485/files#diff-348389ca7460dabf51e1cf3257399fed00174173bf3d4677b9815e42715eac97> (1) - *M* tsl/test/shared/expected/extension.out <https://github.com/timescale/timescaledb/pull/5485/files#diff-4e3f96acd58593e9aa31f4defb955efb123684ae103ccc05465313d68471a4d3> (2) Patch Links: - https://github.com/timescale/timescaledb/pull/5485.patch - https://github.com/timescale/timescaledb/pull/5485.diff — Reply to this email directly, view it on GitHub <#5485>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATJWC4LHDHI2ZAOSK7V5KBDW5Y34HANCNFSM6AAAAAAWHFOJ3A> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Logan Weaver Founder, CEO Surmount AI <https://surmount.ai/>

[syvb]

@LoganSurmount You're watching this repo so you get notifications for everything – you can unwatch it at https://github.com/timescale/timescaledb

[MichaelSaucier]

Hello! Does this fix 1304 as well?
#1304