Optimize recompression for non-segmentby chunks #7632
+367
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7632 +/- ##
==========================================
+ Coverage 80.06% 81.34% +1.27%
==========================================
Files 190 242 +52
Lines 37181 44821 +7640
Branches 9450 11178 +1728
==========================================
+ Hits 29770 36459 +6689
- Misses 2997 3976 +979
+ Partials 4414 4386 -28 ☔ View full report in Codecov by Sentry. |
antekresic
reviewed
Jan 30, 2025
tsl/src/compression/recompress.c
Outdated
| @@ -168,6 +168,10 @@ recompress_chunk_segmentwise_impl(Chunk *uncompressed_chunk) | |||
|
|
|||
| CompressedSegmentInfo *current_segment = palloc0(sizeof(CompressedSegmentInfo) * n_keys); | |||
|
|
|||
| // For chunks with no segmentby settings, we can still do segmentwise recompression | |||
| // The entire chunk is treated as a single segment | |||
| elog(ts_guc_debug_compression_path_info ? INFO : DEBUG1, "using non-segmentby index for recompression") ; | |||
There was a problem hiding this comment.
This will log every time that you are using non-segmentby index but thats not true. You should log the index name you are using instead (its easy to check what index is being used that way).
| @@ -483,7 +483,7 @@ select compressed_chunk_name as compressed_chunk_name_after_recompression from c | |||
| select :'compressed_chunk_name_before_recompression' as before_recompression, :'compressed_chunk_name_after_recompression' as after_recompression; | |||
| before_recompression | after_recompression | |||
| ----------------------------+---------------------------- | |||
| compress_hyper_13_14_chunk | compress_hyper_13_15_chunk | |||
| compress_hyper_13_14_chunk | compress_hyper_13_14_chunk | |||
There was a problem hiding this comment.
Comment above on line 475 needs updating since it is incorrect with this change.
| @@ -291,6 +291,23 @@ insert into nullseg_many values (:'start_time', 1, NULL, NULL); | |||
| SELECT compress_chunk(:'chunk_to_compress'); | |||
| select * from :compressed_chunk_name; | |||
|
|
|||
| -- Test behaviour when no segmentby columns are present | |||
| SET timescaledb.debug_compression_path_info TO ON; | |||
There was a problem hiding this comment.
Lets enable this GUC for the complete test so we can verify that the correct index is being used for each recompression.
kpan2034
force-pushed
the
optimize-non-segmentby
branch
from
5ab9b12 to
151bbf9
Compare
Enables the segmentwise recompression flow to be used for chunks without segmentby columns. This should be more performant than doing a full recompression.
kpan2034
force-pushed
the
optimize-non-segmentby
branch
from
151bbf9 to
26e2e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the segmentwise recompression flow to be used for chunks without segmentby columns.
This should be more performant than doing a full recompression.