Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip function_telemetry.c when telemetry is disabled #7709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hlinnaka
Copy link

@hlinnaka hlinnaka commented Feb 13, 2025

This avoids allocating the telemetry hash table, which saves a little shared memory.

Disable-check: force-changelog-file
Disable-check: loader-change

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fabriziomello
❌ hlinnaka
You have signed the CLA already but the status is still pending? Let us recheck it.

@fabriziomello
Copy link
Contributor

Good catch, thanks @hlinnaka

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (59f50f2) to head (17a2d9d).
Report is 764 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7709      +/-   ##
==========================================
+ Coverage   80.06%   81.93%   +1.86%     
==========================================
  Files         190      246      +56     
  Lines       37181    45116    +7935     
  Branches     9450    11254    +1804     
==========================================
+ Hits        29770    36965    +7195     
- Misses       2997     3733     +736     
- Partials     4414     4418       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello added the loader Issue related to the loader label Feb 14, 2025
hlinnaka and others added 2 commits February 14, 2025 17:02
This avoids allocating the telemetry hash table, which saves a little
shared memory.
@fabriziomello
Copy link
Contributor

Hey @hlinnaka can you please sign the CLA (Contributor Lincense Agreement) in order to get this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loader Issue related to the loader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants