Vectorized grouping by multiple column #7754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paste the values together and use the umash hash of the resulting value for grouping, like we do for the text keys.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7754 +/- ##
==========================================
+ Coverage 80.06% 81.96% +1.89%
==========================================
Files 190 248 +58
Lines 37181 45622 +8441
Branches 9450 11404 +1954
==========================================
+ Hits 29770 37392 +7622
- Misses 2997 3744 +747
- Partials 4414 4486 +72 ☔ View full report in Codecov by Sentry. |
akuzm
commented
Mar 3, 2025
| @@ -225,7 +227,7 @@ add_one_range(GroupingPolicyHash *policy, TupleTableSlot *vector_slot, const int | |||
| * Remember which aggregation states have already existed, and which we | |||
| * have to initialize. State index zero is invalid. | |||
| */ | |||
| const uint32 last_initialized_key_index = policy->last_used_key_index; | |||
| const uint32 last_initialized_key_index = policy->hashing.last_used_key_index; | |||
There was a problem hiding this comment.
Did some mechanical refactoring to move more hashing-related data into the hashing strategy struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paste the values together and use the umash hash of the resulting value for grouping, like we do for the text keys.
Up to 150% improvement on some tsbench queries.