Add warning for poor compression ratio #7756
Draft
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change breaks roughly half our tests, since compressing chunks with only a few rows leads to a bad compression ratio. I considered adding this behind a GUC, which should probably be on by default, but except for testing I don't think there's ever a case where we want it to be OFF. We can either:
However, if we'd like to do more than just emit a warning in the future, then perhaps a GUC makes more sense, since that is something users might like to turn off. What are your thoughts on this @antekresic? |
kpan2034
force-pushed
the
add-compression-warning
branch
from
cb72a87 to
47b4738
Compare
Adds functionality to emit a warning to the user when the compression ratio is "bad". Currently, "bad" is defined to be when size after compression is higher than after compression.
kpan2034
force-pushed
the
add-compression-warning
branch
from
47b4738 to
076e1b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to emit a warning to the user when the compression ratio is bad.