-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict the nightly tests run #7757
base: main
Are you sure you want to change the base?
Restrict the nightly tests run #7757
Conversation
upto the latest release branch. e.g. when this script is back-ported, avoid running it on the last release branch e.g. 2.17.x
@akuzm, @gayyappan: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7757 +/- ##
==========================================
+ Coverage 80.06% 81.93% +1.86%
==========================================
Files 190 247 +57
Lines 37181 45424 +8243
Branches 9450 11353 +1903
==========================================
+ Hits 29770 37216 +7446
- Misses 2997 3737 +740
- Partials 4414 4471 +57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow only runs on schedule and on workflow dispatch.
When running on a schedule, the default branch (main
in our case) should be checked out and the workflow should run there, so I am not sure what problem you are solving with this change.
Could you elaborate?
Hi @mkindahl , In current scenario, we want to run tests on release-branch |
Maybe I'm wrong here , so will check the behaviour on |
upto the latest release branch.
e.g. when this script is back-ported, avoid running it on the last release branch e.g. 2.17.x
Disable-check: force-changelog-file