Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the nightly tests run #7757

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pallavisontakke
Copy link
Contributor

@pallavisontakke pallavisontakke commented Feb 20, 2025

upto the latest release branch.
e.g. when this script is back-ported, avoid running it on the last release branch e.g. 2.17.x

Disable-check: force-changelog-file

upto the latest release branch.
e.g. when this script is back-ported, avoid running it on the last release branch e.g. 2.17.x
Copy link

@akuzm, @gayyappan: please review this pull request.

Powered by pull-review

@github-actions github-actions bot requested review from akuzm and gayyappan February 20, 2025 05:55
@pallavisontakke pallavisontakke requested review from philkra, svenklemm and mkindahl and removed request for akuzm and gayyappan February 20, 2025 05:55
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (59f50f2) to head (45aaf5d).
Report is 785 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7757      +/-   ##
==========================================
+ Coverage   80.06%   81.93%   +1.86%     
==========================================
  Files         190      247      +57     
  Lines       37181    45424    +8243     
  Branches     9450    11353    +1903     
==========================================
+ Hits        29770    37216    +7446     
- Misses       2997     3737     +740     
- Partials     4414     4471      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow only runs on schedule and on workflow dispatch.

When running on a schedule, the default branch (main in our case) should be checked out and the workflow should run there, so I am not sure what problem you are solving with this change.

Could you elaborate?

@pallavisontakke
Copy link
Contributor Author

This workflow only runs on schedule and on workflow dispatch.

When running on a schedule, the default branch (main in our case) should be checked out and the workflow should run there, so I am not sure what problem you are solving with this change.

Could you elaborate?

Hi @mkindahl ,
Right now , this yaml file is on main. When we cut 2.19.x , it'll appear there too. During a minor version release, e.g. 2.19.0 , we'll have 2.18.2 written in downgrade_to_version in version.config . Like during 2.18.0 release, we had 2.17.2 there .

In current scenario, we want to run tests on release-branch 2.18.x and not on 2.17.x too. So the check.

@pallavisontakke
Copy link
Contributor Author

Maybe I'm wrong here , so will check the behaviour on 2.18.x of the existing yaml file first & then get here, if this PR is really needed.

@pallavisontakke pallavisontakke marked this pull request as draft February 20, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants