Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try even lazier decompression #7782

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Feb 28, 2025

Decompress in vectorized aggregation code when the column is required. This improves cache locality.

Decompress in vectorized aggregation code when the column is required.
This improves cache locality.
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 68.33333% with 19 lines in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (59f50f2) to head (a21f936).
Report is 797 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/nodes/decompress_chunk/compressed_batch.c 69.81% 1 Missing and 15 partials ⚠️
tsl/src/nodes/vector_agg/grouping_policy_batch.c 0.00% 0 Missing and 2 partials ⚠️
tsl/src/nodes/vector_agg/grouping_policy_hash.c 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7782      +/-   ##
==========================================
+ Coverage   80.06%   81.89%   +1.82%     
==========================================
  Files         190      247      +57     
  Lines       37181    45467    +8286     
  Branches     9450    11369    +1919     
==========================================
+ Hits        29770    37235    +7465     
- Misses       2997     3754     +757     
- Partials     4414     4478      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant