Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recompress segmentwise when default order by is empty #7789

Conversation

natalya-aksman
Copy link
Contributor

@natalya-aksman natalya-aksman commented Mar 4, 2025

When we have compression where default order by is set to "", we cannot do meaningful segmentwise recompression. Therefore we will return error when segmentwise recompression is requested directly and will do full recompression when general compression is requested.

Fixes: #7748

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.86%. Comparing base (59f50f2) to head (1eba81e).
Report is 803 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/compression/recompress.c 50.00% 0 Missing and 2 partials ⚠️
tsl/src/compression/api.c 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7789      +/-   ##
==========================================
+ Coverage   80.06%   81.86%   +1.80%     
==========================================
  Files         190      247      +57     
  Lines       37181    45442    +8261     
  Branches     9450    11364    +1914     
==========================================
+ Hits        29770    37203    +7433     
- Misses       2997     3766     +769     
- Partials     4414     4473      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenklemm svenklemm requested a review from antekresic March 4, 2025 16:20
@svenklemm svenklemm added this to the v2.19.0 milestone Mar 4, 2025
@natalya-aksman natalya-aksman force-pushed the crash_segmentwise_recompression_i7748 branch from 9738e7a to 224376b Compare March 4, 2025 19:40
@natalya-aksman natalya-aksman force-pushed the crash_segmentwise_recompression_i7748 branch from 224376b to 1eba81e Compare March 4, 2025 19:51
@natalya-aksman natalya-aksman merged commit d7c4244 into timescale:main Mar 4, 2025
47 of 48 checks passed
@timescale-automation
Copy link
Member

Automated backport to 2.18.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.18.x
You are currently cherry-picking commit d7c424441.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .unreleased/pr_7789
	modified:   tsl/src/compression/create.c
	modified:   tsl/src/compression/recompress.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tsl/src/compression/api.c
	both modified:   tsl/test/expected/recompress_chunk_segmentwise.out
	both modified:   tsl/test/sql/recompress_chunk_segmentwise.sql


Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash in the segmentwise recompression
5 participants