-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not recompress segmentwise when default order by is empty #7789
Do not recompress segmentwise when default order by is empty #7789
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7789 +/- ##
==========================================
+ Coverage 80.06% 81.86% +1.80%
==========================================
Files 190 247 +57
Lines 37181 45442 +8261
Branches 9450 11364 +1914
==========================================
+ Hits 29770 37203 +7433
- Misses 2997 3766 +769
- Partials 4414 4473 +59 ☔ View full report in Codecov by Sentry. |
9738e7a
to
224376b
Compare
224376b
to
1eba81e
Compare
Automated backport to 2.18.x not done: cherry-pick failed. Git status
|
When we have compression where default order by is set to "", we cannot do meaningful segmentwise recompression. Therefore we will return error when segmentwise recompression is requested directly and will do full recompression when general compression is requested.
Fixes: #7748