Reduce memory usage when indexing Hypercore TAM #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building indexes over a table using Hypercore TAM, some memory for decompressing data wasn't released until the index build completes. This change optimizes the memory usage during index builds to release memory after every compressed batch has been processed.
mkindahl
approved these changes
Mar 5, 2025
Comment on lines
-2914
to
+2918
| memset(slot->tts_isnull, true, sizeof(bool) * slot->tts_tupleDescriptor->natts); | ||
| MemSet(slot->tts_isnull, true, sizeof(bool) * slot->tts_tupleDescriptor->natts); |
There was a problem hiding this comment.
Nit: PG uses memset as often as MemSet. I think you can stick to memset since most compilers recognize it and can optimize it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7793 +/- ##
==========================================
+ Coverage 80.06% 81.90% +1.83%
==========================================
Files 190 247 +57
Lines 37181 45459 +8278
Branches 9450 11368 +1918
==========================================
+ Hits 29770 37233 +7463
- Misses 2997 3749 +752
- Partials 4414 4477 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gayyappan, @antekresic: please review this pull request.
|
fabriziomello
approved these changes
Mar 5, 2025
fabriziomello
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building indexes over a table using Hypercore TAM, some memory for decompressing data wasn't released until the index build completes. This change optimizes the memory usage during index builds to release memory after every compressed batch has been processed.
Disable-check: force-changelog-file