Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-1820: Menu Toolbar Button Docs page restructuring #3576

Open
wants to merge 4 commits into
base: tinymce/7
Choose a base branch
from
Open

DOC-1820: Menu Toolbar Button Docs page restructuring #3576

wants to merge 4 commits into from
+39 −49

Conversation

LewisAtTiny
Copy link

@LewisAtTiny LewisAtTiny commented Jan 13, 2025 •
edited by FarzadHayat
Loading

Ticket: DOC-1820

Site: Staging branch

Changes:

  • Updated Headings to differentiate how fetch works depending on search is enabled
  • Update text inside the menu button example without search to explain how fetch generates a bunch of possible menu buttons
  • Update text inside the searchable menu button heading to explain how the pattern variable works with fetchContext.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

@LewisAtTiny LewisAtTiny requested a review from a team as a code owner January 13, 2025 01:37
@kemister85
Copy link
Contributor

kemister85 commented Jan 13, 2025 •
edited
Loading

@LewisAtTiny we need to close this PR, and create a new one based off tinymce/7 branch not main.
Branch was updated, ignore this comment.

@FarzadHayat FarzadHayat changed the base branch from main to tinymce/7 January 13, 2025 02:32
@FarzadHayat FarzadHayat requested a review from EkimChau January 13, 2025 02:33
@FarzadHayat
Copy link
Contributor

@kemister85 Fixed. changed the target to tinymce/7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelFromin MichaelFromin Awaiting requested review from MichaelFromin MichaelFromin was automatically assigned from tinymce/documentation-contributors

@abhinavgandham abhinavgandham Awaiting requested review from abhinavgandham abhinavgandham is a code owner

@soritaheng soritaheng Awaiting requested review from soritaheng soritaheng is a code owner

@FarzadHayat FarzadHayat Awaiting requested review from FarzadHayat FarzadHayat is a code owner

@kemister85 kemister85 Awaiting requested review from kemister85 kemister85 is a code owner

@EkimChau EkimChau Awaiting requested review from EkimChau EkimChau is a code owner automatically assigned from tinymce/documentation-team

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LewisAtTiny @kemister85 @FarzadHayat