Call API with add and remove buttons, refine loading and error strategies (#181, 191) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssciolla
force-pushed
the
issue-191-add-remove-api
branch
from
f581348 to
57d1c36
Compare
ssciolla
commented
Jun 13, 2022
| body: JSON.stringify(body), | ||
| headers: { | ||
| ...BASE_MUTATION_HEADERS, | ||
| 'X-CSRFTOKEN': getCSRFToken() ?? '' |
There was a problem hiding this comment.
We could maybe throw an error in getCSRFToken instead, but it seems unlikely that the CSRF token won't be there. And this would still have a clear result, the call would fail with a missing CSRF token message.
ssciolla
commented
Jun 13, 2022
ssciolla
commented
Jun 13, 2022
Comment on lines
+10
to
+17
| defaultOptions: { | ||
| queries: { | ||
| retry: false, | ||
| retryOnMount: false, | ||
| staleTime: Infinity | ||
| }, | ||
| mutations: { retry: false } | ||
| } |
There was a problem hiding this comment.
react-query includes a lot of retry and refetch behavior by default. We may want some of this eventually, but for now I thought it seemed unnecessary and easier for testing to disable it all. See https://react-query.tanstack.com/guides/important-defaults
zqian
reviewed
Jun 16, 2022
ssciolla
force-pushed
the
issue-191-add-remove-api
branch
from
09583dd to
e2f2b94
Compare
zqian
approved these changes
Jun 17, 2022
…kie; add updateToolNav api call; wire up buttons; refactor error and loading handling
ssciolla
force-pushed
the
issue-191-add-remove-api
branch
from
7e3fea5 to
2c09eb4
Compare
jonespm
reviewed
Jun 17, 2022
jonespm
reviewed
Jun 17, 2022
jonespm
approved these changes
Jun 17, 2022
|
FYI, I fixed a styling-related issue, resulting in some extra empty space on the tool cards. Should be resolved now. See b82eab2 |
|
Not sure where the 'extra empty space' was. b82eab2 looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #181 and #191.
More details
apimodule.js-cookieand process for adding a CSRF token to headers.react-queryfor handling asynchronous-related state (useQuery,useMutation).ErrorsDisplay).eslintplugin forreact-hooks.Resources