Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node and Dockerfile to get to build on Openshift #355

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

jonespm
Copy link
Member

@jonespm jonespm commented Nov 14, 2024

Fixes #354
The 3.10-slim is the same as 3.10-slim-bookworm, but this one exists in Openshift

Fixes tl-its-umich-edu#354
The 3.10-slim is the same as 3.10-slim-bookworm, but this one exists in
Openshift
@jonespm jonespm requested a review from pushyamig November 14, 2024 14:56
@jonespm
Copy link
Member Author

jonespm commented Nov 14, 2024

@pushyamig This will cause conflicts to #331 but this will also get what we have building and running on Openshift for now.

Copy link
Contributor

@pushyamig pushyamig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested the changes for change on Dockerfile for openshift. other than that this PR looks OK. Some point we might be deleting Openshift DOcker file and that is file

@jonespm
Copy link
Member Author

jonespm commented Nov 14, 2024

I also noticed that default-libmysqlclient-dev was no longer needed here.

@jonespm jonespm merged commit edc346e into tl-its-umich-edu:main Nov 14, 2024
pushyamig pushed a commit to pushyamig/canvas-app-explorer that referenced this pull request Nov 25, 2024
…h-edu#355)

* Upgrade node and Dockerfile to get to build on Openshift

Fixes tl-its-umich-edu#354
The 3.10-slim is the same as 3.10-slim-bookworm, but this one exists in
Openshift

* Update to match Dockerfile for recent changes

* Remove unneeded mysql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade node and Dockerfiles to get to build on Openshift
2 participants