Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizations for pickapart and repr_l fix for large lists #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joebo
Copy link

@joebo joebo commented Apr 7, 2016

No description provided.

@tlack
Copy link
Owner

tlack commented Apr 8, 2016

Regarding the repr_l bit:

When I was watching the strangeloop video about mathematica.. which you absolutely must see if you havent.. https://www.youtube.com/watch?v=EjCWdsrVcBM

I notice that their REPL shows you not only the start of an item that has been clipped, but also the ending. This seems to me to be much more useful than the Q approach which is to simply stop outputting. Often the record I want is the last one. Of course, it is more complicated to implement that way..

Anyway, that's where there's a continue there instead of a break. So you can see the last end of the non-omitted value.

But the logic was wrong anyway. Can you try out this version and see if it works OK for you?

61f5118

I'll respond separately for these other items.

@tlack
Copy link
Owner

tlack commented Apr 8, 2016

Here's some good testing code btw:
"abcdef" list deal 1000 vec
for strings.. note that "show" will actually output them char-by-char and now use repr_c for UI-usage reasons (i.e., no quotes)..

21 count * 100 :: {count show;}
for vectors and

21 count * 100 :: {count list show;}
for lists

@tlack
Copy link
Owner

tlack commented Apr 8, 2016

OK, I also applied the pickapart fix. I did it as a fresh commit because I had some trouble w/ the merge after I rewrote the other two. Hope that's ok! Keep sending pull requests - this one was just easier to address piece by piece separately.

Let me know if my fixes cause any issues on your end.

t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants