Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

az-account: add page #6204

Merged
merged 12 commits into from
Jul 18, 2021
Merged

az-account: add page #6204

merged 12 commits into from
Jul 18, 2021

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Jul 8, 2021

Signed-off-by: Muhammad Falak R Wani [email protected]

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For: #6141

@mfrw
az-account: add page
def699f 
Signed-off-by: Muhammad Falak R Wani <[email protected]>
@mfrw mfrw added the new command Issues requesting creation of a new page. label Jul 8, 2021
@mfrw mfrw mentioned this pull request Jul 8, 2021
Open
CleanMachine1
CleanMachine1 requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few issues

pages/common/az-account.md Outdated Show resolved Hide resolved
pages/common/az-account.md Outdated Show resolved Hide resolved
pages/common/az-account.md Outdated Show resolved Hide resolved
pages/common/az-account.md Outdated Show resolved Hide resolved
pages/common/az-account.md Outdated Show resolved Hide resolved
marchersimon
marchersimon reviewed Jul 8, 2021
View reviewed changes
pages/common/az-account.md Outdated Show resolved Hide resolved
pages/common/az-account.md Outdated Show resolved Hide resolved
pages/common/az-account.md Outdated Show resolved Hide resolved
mfrw and others added 3 commits July 8, 2021 20:27
marchersimon
marchersimon approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfrw

CleanMachine1
CleanMachine1 approved these changes Jul 16, 2021
View reviewed changes
pages/common/az-account.md Show resolved Hide resolved
pages/common/az-account.md Outdated Show resolved Hide resolved
@mfrw
Copy link
Member Author

mfrw commented Jul 18, 2021 •
edited
Loading

btw, adding all the folks who helped to shape this page in the commit log :)

@mfrw mfrw merged commit 8b934dd into tldr-pages:main Jul 18, 2021
@marchersimon
Copy link
Collaborator

@mfrw actually we should empty the message body, but I don't really know why. @sbrl do you know why we are doing that?

@mfrw mfrw deleted the mfrw/az-account branch October 23, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchersimon marchersimon marchersimon approved these changes

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfrw @marchersimon @navarroaxel @CleanMachine1