Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

az-upgrade: add page #8555

Merged
merged 3 commits into from
Oct 1, 2022
Merged

az-upgrade: add page #8555

merged 3 commits into from
Oct 1, 2022

Conversation

derNiklaas
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.40.0

Part of #6141

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Sep 30, 2022
CleanMachine1
CleanMachine1 reviewed Sep 30, 2022
View reviewed changes
pages/common/az-upgrade.md Outdated

- Upgrade Azure CLI and Extensions:

`az upgrade --all {{true|false}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if false is selected, what isn't updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --all flag enables Extension upgrades. So if false is selected, it won't upgrade the Extensions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a different command example for just updating Azure CLI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably remove the {{true|false}} as it can be confusing. It's optional anyways and defaults to true.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/az-upgrade.md:7: TLDR014 Page should contain no trailing whitespace

Please fix the error(s) and push again.

CleanMachine1
CleanMachine1 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@CleanMachine1 CleanMachine1 added the review needed Prioritized PRs marked for reviews from maintainers. label Sep 30, 2022
@mfrw mfrw added the hacktoberfest For DigitalOcean's Hacktoberfest, an event that occurs every October label Oct 1, 2022
mfrw
mfrw approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Thank you @derNiklaas for your contirbution.

@mfrw mfrw added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 1, 2022
@mfrw mfrw merged commit 649b400 into tldr-pages:main Oct 1, 2022
@navarroaxel navarroaxel removed the review needed Prioritized PRs marked for reviews from maintainers. label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

@mfrw mfrw mfrw approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
hacktoberfest For DigitalOcean's Hacktoberfest, an event that occurs every October hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@derNiklaas @tldr-bot @mfrw @kbdharun @CleanMachine1 @navarroaxel