Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): support text highlight html adapter #9632

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Jan 10, 2025

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@donteatfriedrice donteatfriedrice marked this pull request as ready for review January 10, 2025 09:52
@donteatfriedrice donteatfriedrice requested a review from a team as a code owner January 10, 2025 09:52
@graphite-app graphite-app bot requested a review from forehalo January 10, 2025 09:52
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (c016f8e) to head (9fd1c65).

Files with missing lines Patch % Lines
...src/rich-text/inline/adapters/html/inline-delta.ts 53.84% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9632      +/-   ##
==========================================
+ Coverage   52.82%   52.83%   +0.01%     
==========================================
  Files        2180     2180              
  Lines       98546    98573      +27     
  Branches    16748    16756       +8     
==========================================
+ Hits        52052    52083      +31     
+ Misses      45055    45045      -10     
- Partials     1439     1445       +6     
Flag Coverage Δ
server-test 77.77% <ø> (-0.06%) ⬇️
unittest 32.29% <37.77%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jan 10, 2025

Merge activity

  • Jan 10, 9:45 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 10, 10:16 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (PR has had changes requested).
  • Jan 10, 11:07 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@donteatfriedrice donteatfriedrice force-pushed the 01-10-feat_editor_support_text_highlight_html_adapter branch from 18ad497 to 9fd1c65 Compare January 10, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants