Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(editor): update default colors of shape #9633

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jan 10, 2025

Closes: PD-2176

  • updates shape's text color to the #000000ff and custom button should be selected by default in color picker
  • updates shape background default color palette to medium

Copy link
Contributor Author

fundon commented Jan 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon marked this pull request as ready for review January 10, 2025 10:38
@fundon fundon requested a review from a team as a code owner January 10, 2025 10:38
@graphite-app graphite-app bot requested a review from forehalo January 10, 2025 10:38
@fundon fundon marked this pull request as draft January 10, 2025 10:44
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.83%. Comparing base (5b92567) to head (9b140c6).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9633      +/-   ##
==========================================
- Coverage   53.09%   52.83%   -0.26%     
==========================================
  Files        2180     2180              
  Lines       98540    98541       +1     
  Branches    16795    16752      -43     
==========================================
- Hits        52320    52065     -255     
- Misses      44773    45032     +259     
+ Partials     1447     1444       -3     
Flag Coverage Δ
server-test 77.77% <ø> (-0.77%) ⬇️
unittest 32.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/01_10_update_default_colors_of_shape branch from d025ecd to 48842aa Compare January 10, 2025 15:26
@fundon fundon force-pushed the fundon/01_10_update_default_colors_of_shape branch from 48842aa to c2795bc Compare January 11, 2025 08:01
@fundon fundon force-pushed the fundon/01_10_update_default_colors_of_shape branch from c2795bc to 9b140c6 Compare January 11, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant