Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-sys. #1820

Closed
wants to merge 3 commits into from
Closed

Conversation

westy92
Copy link

@westy92 westy92 commented Aug 6, 2024

@Thomasdezeeuw
Copy link
Collaborator

Should probably coordinate with Tokio on this.

/cc @Darksonn

@Darksonn
Copy link
Contributor

Darksonn commented Aug 7, 2024

Yes. I don't think we need to force people to only use Tokio/mio combinations with the same windows-sys, but we should also update it in Tokio.

@Thomasdezeeuw
Copy link
Collaborator

@westy92 are you running the tests locally? Or only using the CI for testing?

@westy92
Copy link
Author

westy92 commented Aug 17, 2024

@Thomasdezeeuw tests are passing on my Mac, but I am unable to test on Windows.

@Thomasdezeeuw
Copy link
Collaborator

Since this is failing the CI and no progress has been made to fix it I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants