rt: coop should yield using waker defer strategy #7185
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #5223 introduces a waker defer list to handle yielding tasks. This defer list enables the runtime to poll the driver between yields. Previously, the coop path did not use the defer yield path which prevents the runtime driver from being checked. This PR updates the coop yield logic to use the defer strategy.
carllerche
added
C-bug
|
It looks like the quinn tests are flaky. |
Darksonn
reviewed
Feb 28, 2025
| if use_coop { | ||
| // Consume a good chunk of budget, which should | ||
| // force at least one yield. | ||
| for _ in 0..200 { |
There was a problem hiding this comment.
We have a fair number of tests that declare a const BUDGET: usize = 128; constant. It would be good to do the same here so we can grep for tests that assume what the budget is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5223 introduces a waker defer list to handle yielding tasks. This defer list enables the runtime to poll the driver between yields. Previously, the coop path did not use the defer yield path, preventing the runtime driver from being checked. This PR updates the coop yield logic to use the defer strategy.
Merging this PR should be coordinated with #7164.