Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querying for "custom_rendition_property" in the example, results in error #318

Closed
engAmirEng opened this issue Feb 25, 2023 · 2 comments
Closed

querying for "custom_rendition_property" in the example, results in error #318

engAmirEng opened this issue Feb 25, 2023 · 2 comments

Comments

@engAmirEng
Copy link
Contributor

"Cannot return null for non-nullable field CustomImageRendition.customRenditionProperty." is the result of querying the "custom_rendition_property" while we have this:

wagtail-grapple/example/images/models.py

Lines 24 to 28 in 1bd7972

def custom_rendition_property(self, info, **kwargs):
return "Rendition Model!"
graphql_fields = (
GraphQLString("custom_rendition_property", required=True),

@engAmirEng engAmirEng changed the title querying for "custom_rendition_property" in the example result's in error querying for "custom_rendition_property" in the example, results in error Feb 25, 2023
@engAmirEng
Copy link
Contributor Author

Even in #312 this behavior continues to exist, I don't understand why

engAmirEng added a commit to engAmirEng/wagtail-grapple that referenced this issue May 15, 2023
@engAmirEng
fix resolve_rendition, instantiating ImageRenditionObjectType by hand?!
5fdc008 
this fixes torchbox#318
@engAmirEng engAmirEng mentioned this issue May 15, 2023
Closed
@zerolab
Copy link
Member

zerolab commented Jul 10, 2023

Fix in #337

@zerolab zerolab closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix resolve_rendition, instantiating ImageRenditionObjectType by hand?! engAmirEng/wagtail-grapple
2 participants
@zerolab @engAmirEng