fix resolve_rendition, instantiating ImageRenditionObjectType by hand?! #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
reviewed
May 17, 2023
tests/test_grapple.py
Outdated
| @@ -1005,6 +1005,7 @@ def test_query_url_field(self): | |||
| executed["data"]["images"][0]["url"], executed["data"]["images"][0]["src"] | |||
| ) | |||
|
|
|||
| @unittest.skip | |||
There was a problem hiding this comment.
This indicates that perhaps your changes break intended functionality
Please do not skip tests unless there's a specific reason for it, and when you do you should add a reason for it. ref
There was a problem hiding this comment.
Sure, at least I did it in a separate commit😌
Aside from that, you know this pull request fixes a necessary functionality that grapple claims it has but it doesn't, right?
|
Thank you for this, @engAmirEng |
Happy to see the repo is going forward🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #318
not sure why they did instantiate the ImageRenditionObjectType by hand instead of returning the Rendition instance in the first place
the faling test is "test_query_rendition_url_field" and there is no way to fix it until #329 is merged