Upgrade testing for Wagtail 6.3 #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Removes Python 3.8 from the test matrix. - Adds Django 5.1 to the test matrix. - Updates the classifiers in `pyproject.toml` to include Django 5.1 and Wagtail 6.3. - Updates the `tox.ini` file to include Django 5.1 and Wagtail 6.3 in the test matrix.
|
There is a deprecation warning for: https://docs.wagtail.org/en/stable/releases/6.0.html#deprecated-widgetwithscript-base-widget-class but I think that should be a separate piece of work and isn't included here. |
Closed
zerolab
reviewed
Nov 20, 2024
Comment on lines
+16
to
+26
| - uses: actions/checkout@v4 | ||
| - name: Install Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install ruff | ||
| - name: Run Ruff | ||
| run: ruff check --output-format=github ./src/wagtailmarkdown |
There was a problem hiding this comment.
These changes are not needed.
What we do need is to install the same ruff version as in pre-commit https://github.com/torchbox/wagtail-markdown/blob/main/.pre-commit-config.yaml#L23C11-L23C17
a la https://github.com/torchbox/wagtail-periodic-review/blob/main/.github/workflows/ruff.yml
zerolab
reviewed
Nov 20, 2024
| py{311,312}-django5.0-wagtail{5.2,6.0,main} | ||
| py{39,310,311}-django4.2-wagtail{5.2,6.2,6.3} | ||
| py{311,312}-django5.0-wagtail{5.2,6.2,6.3} | ||
| py{311,312}-django5.1-wagtail{6.3,main} |
There was a problem hiding this comment.
let's add Python 3.13 to the mix too
Merged
|
closing in favour of #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes: updates to the CI workflows and testing configurations to remove support for Python 3.8 and Django 3.2, and to add support for newer versions of Django and Wagtail.
CI Workflow Updates:
.github/workflows/ci.yml: Removed Python 3.8 from the matrix of Python versions..github/workflows/ruff.yml: Updated the Ruff workflow to useactions/setup-python@v5and install dependencies with Python 3.12.Dependency Management:
pyproject.toml: Removed classifiers for Python 3.8 and Django 3.2, and added a classifier for Django 5.1.Testing Configuration:
tox.ini: Updated theenvlistto remove Python 3.8 and add configurations for Django 5.1 and newer versions of Wagtail.tox.ini: Updateddepsto remove Django 3.2 and add Django 5.1 and newer versions of Wagtail.