Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly test for Wagtail 6.3 / Django 5.1 #250

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

gasman
Copy link
Member

@gasman gasman commented Nov 4, 2024

  • update Postgres to v15
  • replace assertQuerysetEqual with assertQuerySetEqual

@gasman gasman marked this pull request as draft November 4, 2024 10:44
@zerolab
Copy link
Member

zerolab commented Nov 4, 2024

@gasman https://github.com/torchbox/wagtailmedia/blob/main/.github/workflows/test.yml#L65-L68 needs if-no-files-found: ignore and we're good to go

@gasman
Copy link
Member Author

gasman commented Nov 4, 2024

@zerolab Where does that need to be added? (The lines you link to already have it...)

@zerolab
Copy link
Member

zerolab commented Nov 4, 2024

gah, copied the wrong line. It needs include-hidden-files: true

@gasman gasman force-pushed the fix/nightly-test-postgres-15 branch from 43f9d27 to 1f5e87d Compare November 4, 2024 11:46
@gasman
Copy link
Member Author

gasman commented Nov 4, 2024

Now rebased to remove the temporary "run nightly tests on PR" addition - https://github.com/torchbox/wagtailmedia/actions/runs/11663518640/job/32472102881 shows the nightly run completing successfully.

@gasman gasman marked this pull request as ready for review November 4, 2024 11:48
@gasman gasman changed the title Update nightly test script to run against supported Postgres version Fix nightly test for Wagtail 6.3 / Django 5.1 Nov 4, 2024
@zerolab zerolab merged commit 7134319 into torchbox:main Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants