Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize Embedding extractor args. #1762

Merged
merged 0 commits into from
Aug 19, 2022
Merged

Conversation

zc277584121
Copy link
Contributor

Signed-off-by: ChengZi [email protected]

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zc277584121
To complete the pull request process, please assign fzliu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fzliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1762 (c2b0e2b) into main (e4a0b60) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1762      +/-   ##
==========================================
+ Coverage   72.14%   72.20%   +0.05%     
==========================================
  Files         384      384              
  Lines       21874    21875       +1     
  Branches     3524     3524              
==========================================
+ Hits        15781    15794      +13     
+ Misses       5096     5082      -14     
- Partials      997      999       +2     
Impacted Files Coverage Δ
towhee/models/embedding/embedding_extractor.py 86.36% <100.00%> (+0.64%) ⬆️
towhee/engine/operator_context.py 82.60% <0.00%> (ø)
towhee/engine/graph_context.py 90.76% <0.00%> (+4.61%) ⬆️
towhee/engine/task_scheduler.py 71.60% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zc277584121 zc277584121 requested review from jaelgu and oneseer and removed request for reiase and Chiiizzzy August 19, 2022 05:58
@zc277584121 zc277584121 merged commit 2bbc986 into towhee-io:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants