Don't hydrate if block is null. Avoid 404 from API.

tpenaranda · Sep 7, 2018 · 7cf0f55 · 7cf0f55
1 parent 58304a7
commit 7cf0f55
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Models/Transaction.php b/src/Models/Transaction.php
@@ -43,14 +43,14 @@ protected function addAmountTransactedToWalletSatoshiAttribute()
         }
 
         return Cache::rememberForever("tpenaranda-bcoin:amount-in-satoshi-transacted-tx_hash:{$this->hash}-wallet_id:{$this->wallet_id}", function () {
-            if (empty($this->inputs[0]->coin) || empty($transaction->fee)) {
-                $this->hydrate($this->getDataFromBlockchain());
-            }
-
             if (empty($this->block)) {
                 return null;
             }
 
+            if (empty($this->inputs[0]->coin) || empty($transaction->fee)) {
+                $this->hydrate($this->getDataFromBlockchain());
+            }
+
             $total_inputs_own_wallet = $total_outputs_own_wallet = 0;
 
             foreach ($this->inputs as $input) {