Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request continues the conversation in #142 and adds support for NAT-PMP.
Some remarks:
/config/protonvpn-port-tcp.txt
and/config/protonvpn-port-udp.txt
inside the Docker containernatpmpc
update loop, I manually try to connect one time with TCP and UDP and only signal connection successful if these commands succeed.I tested this using Docker and it works. Example Docker config:
Important
Make sure to
touch
protonvpn-port-tcp.txt
andprotonvpn-port-udp.txt
before starting the containeer or Docker will make it a directory and it wont work.Let me know what you think!