Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress ResizeObserver error overlay in dev mode #1800

Merged
merged 1 commit into from
Feb 4, 2025
Merged

suppress ResizeObserver error overlay in dev mode #1800

merged 1 commit into from
Feb 4, 2025

Conversation

SlicedSilver
Copy link
Contributor

Note: This doesn't affect the library code, or built version of the documentation. Purely for development mode of the website.

Suppresses the "ResizeObserver loop completed with undelivered notification" error overlay that appears during development. This is a harmless error that occurs during React development mode and doesn't affect production builds.

The error will still be logged to the console but won't disrupt development by showing the error overlay.

@SlicedSilver
suppress ResizeObserver error overlay in dev mode
2a87394 
Add webpack configuration to prevent the "ResizeObserver loop completed with
undelivered notification" error from appearing in the development overlay.
The error will still be logged to the console but won't block the UI with
an error overlay during development.
@SlicedSilver SlicedSilver added the website Related to the documentation website, but not it’s content. label Feb 4, 2025
@SlicedSilver SlicedSilver self-assigned this Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

size-limit report 📦

Path Size
ESM 44.84 KB (+0.12% 🔺)
ESM createChart 36.84 KB (0%)
ESM createChartEx 35.56 KB (0%)
ESM createYieldCurveChart 37 KB (0%)
ESM createOptionsChart 35.79 KB (0%)
Standalone-ESM 46.29 KB (-0.02% 🔽)
Standalone 46.27 KB (+0.1% 🔺)
Plugin: Text Watermark 1.87 KB (0%)
Plugin: Image Watermark 1.69 KB (0%)
Plugin: Series Markers 3.98 KB (0%)
Series: LineSeries 2.54 KB (0%)
Series: BaselineSeries 3.2 KB (0%)
Series: AreaSeries 3.12 KB (0%)
Series: BarSeries 2.15 KB (0%)
Series: CandlestickSeries 2.42 KB (0%)
Series: HistogramSeries 2.18 KB (0%)
Plugin: UpDownMarkersPrimitive 2.37 KB (0%)

@SlicedSilver SlicedSilver marked this pull request as ready for review February 4, 2025 15:10
romfrancois
romfrancois approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@romfrancois romfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - joy of using React :)

@romfrancois romfrancois merged commit 8ece858 into master Feb 4, 2025
33 checks passed
@romfrancois romfrancois deleted the suppress-runtime-error-on-website-dev-mode branch February 4, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romfrancois romfrancois romfrancois approved these changes

Assignees

@SlicedSilver SlicedSilver

Labels
website Related to the documentation website, but not it’s content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlicedSilver @romfrancois