Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP3): split udp and tcp Service when service.single is false #1168

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mloiseleur
Copy link
Contributor

What does this PR do?

Allows to split TCP and UCP Service when enabling http3.

Motivation

The recent changes on Service has broken this feature. It can be useful to avoid known issues with Kubernetes on mixed procotols like #982.
Fixes #1167.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 24acadf into traefik:master Aug 27, 2024
1 check passed
@mloiseleur mloiseleur deleted the fix/service-single branch September 18, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service.single false does not work
3 participants