docs: 📝 document CRDs technical choices #1321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
reviewed
Jan 28, 2025
mloiseleur
reviewed
Jan 29, 2025
mloiseleur
reviewed
Jan 29, 2025
mloiseleur
reviewed
Jan 29, 2025
Co-authored-by: Michel Loiseleur <[email protected]>
darkweaver87
changed the title
mloiseleur
reviewed
Jan 31, 2025
mloiseleur
reviewed
Jan 31, 2025
|
Overall, lgtm. See my last comment for style improvement. |
darkweaver87
force-pushed
the
feat/doc-crds
branch
2 times, most recently
from
ac1108d to
0a64b7e
Compare
Co-authored-by: Michel Loiseleur <[email protected]>
darkweaver87
force-pushed
the
feat/doc-crds
branch
from
0a64b7e to
a80e636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
More
make testand all the tests passed