Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ add missing consulCatalogEnterprise provider for Hub #1324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: ✨ add missing consulCatalogEnterprise provider for Hub #1324

wants to merge 3 commits into from

Conversation

darkweaver87
Copy link
Contributor

@darkweaver87 darkweaver87 commented Jan 28, 2025 •
edited
Loading

What does this PR do?

This PR adds consulCatalogEnterprise configuration for Hub.

Motivation

Feel the gap of missing configurations for Hub.

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

mloiseleur
mloiseleur reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@mloiseleur mloiseleur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt of having a test with minimal required configuration and a test with all parameters set (and so checked) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darkweaver87 @mloiseleur @traefiker