Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 hub version not handling main builds #1326

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: 🐛 hub version not handling main builds #1326

wants to merge 2 commits into from

Conversation

darkweaver87
Copy link
Contributor

@darkweaver87 darkweaver87 commented Jan 29, 2025 •
edited
Loading

What does this PR do?

This PR fixes a bug introduced in last release where we added requirements on hub version.

Motivation

Checking hub version can fail in some CI checks during Hub release process.

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

mloiseleur
mloiseleur reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkweaver87 There is another use case to cover, see my suggestion on test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkweaver87 @mloiseleur