-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Traefik Hub): AIServices are available in API Gateway #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkweaver87
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mloiseleur
changed the title
aiservices are available in Hub API GW
fix(Traefik Hub): AISServices are available in Hub API GW
Feb 6, 2025
mloiseleur
changed the title
fix(Traefik Hub): AISServices are available in Hub API GW
fix(Traefik Hub): AIServices are available in Hub API GW
Feb 6, 2025
mloiseleur
changed the title
fix(Traefik Hub): AIServices are available in Hub API GW
fix(Traefik Hub): AIServices are available in API Gateway
Feb 6, 2025
mloiseleur
previously approved these changes
Feb 6, 2025
mloiseleur
added
status/3-needs-merge
bot/no-merge
and removed
status/2-needs-review
status/3-needs-merge
labels
Feb 6, 2025
mloiseleur
reviewed
Feb 6, 2025
mloiseleur
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestion.
mloiseleur
approved these changes
Feb 7, 2025
Co-authored-by: Michel Loiseleur <[email protected]>
traefiker
force-pushed
the
fix-aiservice
branch
from
February 7, 2025 16:04
bfb778f
to
07c5283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves the rbac for aiservices to Hub API GW instead of only Hub APIM
Motivation
Be able to use AIServices in Hub API GW
More
make test
and all the tests passed