Operation policies #3293
Open
Operation policies #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
balanza,
nelsonkopliku,
CDimonaco and
gagandeepb
There was a problem hiding this comment.
Hey @arbulu89 a few questions and typos.
I believe the mob review will answer those, and then I will review again.
Co-authored-by: Nelson Kopliku <[email protected]>
arbulu89
force-pushed
the
operation-policies
branch
from
6e048d9 to
9b73aa3
Compare
arbulu89
force-pushed
the
operation-policies
branch
from
c65fbfe to
386b91d
Compare
nelsonkopliku
approved these changes
Feb 13, 2025
CDimonaco
approved these changes
Feb 13, 2025
gagandeepb
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add operations framework policy. It tries to replicate what we do with
Bodyguardfor the user authorizations.The operations that will be executed in the trento agents are really sensitive, so this policies guard them against incorrect usage. They will protect the operation new endpoints, so the users cannot run the operations if the resources are not in good state.
This is just the first model. We can add more conditions, and of course, more operations.
By now I have included the
saptune_solution_applymain operation, which depends on having the SAP instances in a maintainable state:. The cluster can have maintenance operations if it is actually in maintenance mode
. Or the resource that will be changed is not managed
. The instances are not running
. Cluster is in maintenance
. All the SAP instances running on this host are in maintenance mode
PD:
Here a ref with SUSE docs explaining a general way of doing SAP maintenance (like applying saptune) in clustered nodes: https://documentation.suse.com/sbp/sap-15/html/SLES4SAP-hana-sr-guide-PerfOpt-15/index.html#id-maintenance
How was this tested?
UT