Foundation for Basic Analytics Implementation #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagabomb
commented
Feb 14, 2025
| @@ -13,7 +13,7 @@ defmodule Trento.Settings.InstallationSettings do | |||
| @derive {Jason.Encoder, except: [:__meta__, :__struct__]} | |||
| @primary_key {:id, :binary_id, autogenerate: true} | |||
| schema "settings" do | |||
| field :eula_accepted, :boolean, source: :installation_settings_eula_accepted | |||
| # field :eula_accepted, :boolean, source: :installation_settings_eula_accepted | |||
There was a problem hiding this comment.
This line has been commented out to enable installation_id to be returned. I would be interested in another way to solve this since eula_accepted column seems to have been removed from the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to incorporate a basic implementation of Analytics with Posthog using its autocapture feature and a custom view for pageviews (due to react SPA).
This also adds configurable values for to:
Additional PRs will be created for tasks like:
How was this tested?
Describe the tests that have been added/changed for this new behavior.
Did you update the documentation?
Add a documentation PR or write that no changes are required for the documentation.