Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezorctl drastically decrease quality of uploaded homescreen #3893

Closed
Hannsek opened this issue Jun 4, 2024 · 2 comments
Closed

trezorctl drastically decrease quality of uploaded homescreen #3893

Hannsek opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working as expected trezorlib Python library and the command line trezorctl tool.

Comments

@Hannsek
Copy link
Contributor

Hannsek commented Jun 4, 2024

Quality of jpgs uploaded through trezorctl is way worse then quality of jpgs uploaded to device through suite.
@Hannsek Hannsek added the bug Something isn't working as expected label Jun 4, 2024
@Hannsek Hannsek added this to Firmware Jun 4, 2024
@Hannsek Hannsek added the trezorlib Python library and the command line trezorctl tool. label Jun 4, 2024
@matejcik
Copy link
Contributor

matejcik commented Jun 4, 2024

would be interesting to see Suite-produced jpeg alongside trezorctl's.
can Suite dump the jpeg that it is sending to device?

@Hannsek
Copy link
Contributor Author

Hannsek commented Jun 4, 2024

Let's wait for this discussion.

matejcik added a commit that referenced this issue Jun 12, 2024
@matejcik
fix(python): increase homescreen quality when uploading via trezorctl
01087ab 
fixes #3893
@matejcik matejcik mentioned this issue Jun 12, 2024
Closed
matejcik added a commit that referenced this issue Jun 19, 2024
@matejcik
fix(python): increase homescreen quality when uploading via trezorctl
3b94337 
fixes #3893
matejcik added a commit that referenced this issue Jun 20, 2024
@matejcik
fix(python): increase homescreen quality when uploading via trezorctl
1789a43 
fixes #3893
matejcik added a commit that referenced this issue Jun 25, 2024
@matejcik
fix(python): increase homescreen quality when uploading via trezorctl
7e484fe 
fixes #3893
matejcik added a commit that referenced this issue Jun 25, 2024
@matejcik
fix(python): increase homescreen quality when uploading via trezorctl
5322a36 
fixes #3893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected trezorlib Python library and the command line trezorctl tool.
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(python): increase homescreen quality when uploading via trezorctl trezor/trezor-firmware
2 participants
@matejcik @Hannsek