Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): increase homescreen quality when uploading via trezorctl #3945

Closed
wants to merge 1 commit into from

Conversation

matejcik
Copy link
Contributor

fixes #3893

@matejcik matejcik requested a review from Hannsek June 12, 2024 09:51
@matejcik
Copy link
Contributor Author

@Hannsek adding you as a reviewer so that you can test it and see if it makes you happier :)

@Hannsek
Copy link
Contributor

Hannsek commented Jun 12, 2024

Why do you introduce quality flag?
Cannot it be just set to max that would fit every time?

@matejcik
Copy link
Contributor Author

I also set the default quality to 90 which should be good for everyone.
"max quality that would fit" is not great because it would push the image quality towards the 16 kB limit every time, while in practice it's useful to have the homescreen as small as possible. (also we'd need to iterate the quality, perhaps resize multiple times before we figure out the max possible quality.

this way we set a reasonable default, while allowing tinkerers to (a) push for greater quality or (b) fit a more complex image within the limit

@matejcik
Copy link
Contributor Author

(before this, the default quality was 75 in the jpeg library)

@matejcik matejcik mentioned this pull request Jun 19, 2024
@matejcik
Copy link
Contributor Author

superseded by #3963

@matejcik matejcik closed this Jun 25, 2024
@matejcik matejcik deleted the matejcik/trezorctl-homescreen-quality branch June 25, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

trezorctl drastically decrease quality of uploaded homescreen
2 participants