refactor(core/mercury): unify confirm TOS #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrusvit
requested review from
mmilata
and removed request for
prusnak and
matejcik
mmilata
approved these changes
Jul 28, 2024
obrusvit
force-pushed
the
refactor/ui-t3t1/unify-tos-confirm
branch
from
68dd3c2 to
374330b
Compare
[no changelog]
obrusvit
force-pushed
the
refactor/ui-t3t1/unify-tos-confirm
branch
from
374330b to
1357142
Compare
|
Rebased again because of forgotten |
|
QA OK Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies confirming Terms of Service (TOS) screen on T3T1. It saves only less than
1KBof debug flash (I expected more but..).In the future, it wouldn't be bad to replace it with
ConfirmActionbut there are difficulties: 1) TOS has different text style, 2) choosing text for cancel button in menu. We do not want to pollute the implementation of confirm action with additional params.