Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase ShortString size to 128, to support longer passphrases #4531

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Increase ShortString size to 128, to support longer passphrases #4531

wants to merge 3 commits into from

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Jan 23, 2025 •
edited
Loading

Fixes #4084.

@romanz romanz added the translations Put this label on a PR to run tests in all languages label Jan 23, 2025
@romanz romanz self-assigned this Jan 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz
refactor(core): define MAX_PASSPHRASE_LENGTH once
8b4286f 
Instead of defining it per-layout.

[no changelog]
@romanz romanz mentioned this pull request Jan 26, 2025
Closed
@romanz romanz force-pushed the romanz/increase-passphrase branch from 46ecf86 to dba63dd Compare January 26, 2025 08:56
@romanz romanz linked an issue Jan 26, 2025 that may be closed by this pull request
Remove 50 character limit from passphrase #4084
Open
@romanz romanz changed the title WIP: Increase passphrase size Increase ShortString size to 128, to support longer passphrases Jan 26, 2025
@romanz romanz force-pushed the romanz/increase-passphrase branch from dba63dd to 449b4d8 Compare January 26, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik Awaiting requested review from matejcik matejcik will be requested when the pull request is marked ready for review matejcik is a code owner

@prusnak prusnak Awaiting requested review from prusnak prusnak will be requested when the pull request is marked ready for review prusnak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@romanz romanz

Labels
translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: 🏃‍♀️ In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove 50 character limit from passphrase
1 participant
@romanz