style: add make changelog_style for automatic changelog formatting
#4532
+65
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added also to `make style`. [no changelog]
|
matejcik
reviewed
Jan 24, 2025
Makefile
Outdated
| ./tools/generate-changelog.py --fix-style legacy/bootloader | ||
| ./tools/generate-changelog.py --fix-style legacy/firmware | ||
| ./tools/generate-changelog.py --fix-style legacy/intermediate_fw | ||
| ./tools/generate-changelog.py --fix-style python |
There was a problem hiding this comment.
this is becoming rather fragile, instead embed this list into generate-changelog
and make it fail if someone tries to use a non-listed path, telling them to also add the thing they want to the known path list
(that way we have a single command for "changelog check" and "changelog style" and we enforce that every changelog used by someone will be added to that list)
There was a problem hiding this comment.
Sounds good, thanks for the suggestion!
WDYT about 0132526?
There was a problem hiding this comment.
(I've also added @mmilata, since he is the author of tools/generate-changelog.py)
…atting Also, rename `generate-changelog.py` to `changelog.py`, in order to support mulitple subcommands (`generate`, `check`, `style`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added also to
make style.[no changelog]